Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KtLint 0.34+ #469

Merged
merged 9 commits into from
Oct 7, 2019
Merged

Support KtLint 0.34+ #469

merged 9 commits into from
Oct 7, 2019

Conversation

ZacSweers
Copy link
Contributor

This resolves #419 by invoking the new format(Params) API in KtLint 0.34+. This API also lays groundwork for adding editorconfig in the future since the new Params API allows specifying one. Opportunistically also fixed some stale names in 3812713.

Starting this now for early review, will add a test next.

@ZacSweers
Copy link
Contributor Author

Reverting part of 3812713, realize why the naming was as such before now

@nedtwigg
Copy link
Member

nedtwigg commented Oct 6, 2019

As you say - needs test, but looks great!

@ZacSweers
Copy link
Contributor Author

Actually no new test needed. The default behavior() test covers this now, and the existing worksPinterest() test acts as a regression test for the old behavior on [0.32.0-0.34.0). Just clarified it in 9c5c264

@nedtwigg
Copy link
Member

nedtwigg commented Oct 6, 2019

Updated the changelogs. This LGTM. I'll merge and release late tonight / early tomorrow unless I hear otherwise from somebody.

@ZacSweers
Copy link
Contributor Author

ZacSweers commented Oct 6, 2019 via email

@ZacSweers
Copy link
Contributor Author

Made just a couple touchups to the comments and trailing paren formatting. Comments weren't quite right before

@ZacSweers
Copy link
Contributor Author

Spotless overwrote my paren formatting

@nedtwigg nedtwigg merged commit 238fd08 into diffplug:master Oct 7, 2019
@ZacSweers ZacSweers deleted the z/updateKtLint branch October 7, 2019 03:20
@nedtwigg
Copy link
Member

nedtwigg commented Oct 7, 2019

Released in 3.25.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ktLint 0.34 changes not compatible with spotless
2 participants